From 5db603a56169a2f86732728d8eeb6c2049417229 Mon Sep 17 00:00:00 2001 From: Jimi Xenidis Date: Fri, 11 Aug 2006 13:30:48 -0400 Subject: [PATCH] [POWERPC] start-cpu has no return code According to this document: PowerPC Processor binding to: IEEE 1275-1994 Standard for Boot (Initialization, Configuration) Firmware Revision: 2.1 (Approved Version) Date: November 6, 1996 The start-cpu client interface has the following signature: start-cpu IN: nodeid, pc, arg OUT: none This patch reflects that, and makes us stop seeing a bogus OF_FAILURE if we do actually check the return code of of_start_cpu. Tested on JS20 and JS21 blades. Signed-off-by: Amos Waterland Signed-off-by: Hollis Blanchard --- xen/arch/powerpc/boot_of.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/xen/arch/powerpc/boot_of.c b/xen/arch/powerpc/boot_of.c index a450b7de9a..57465e7bc0 100644 --- a/xen/arch/powerpc/boot_of.c +++ b/xen/arch/powerpc/boot_of.c @@ -304,12 +304,11 @@ static int __init of_instance_to_path(int ih, char *buffer, u32 buflen) static int __init of_start_cpu(int cpu, u32 pc, u32 reg) { - int rets[1] = { OF_FAILURE }; + int ret; - if ( of_call("start-cpu", 3, 0, rets, cpu, pc, reg) == OF_FAILURE ) - return OF_FAILURE; + ret = of_call("start-cpu", 3, 0, NULL, cpu, pc, reg); - return rets[0]; + return ret; } static void __init of_test(const char *of_method_name) -- 2.30.2